Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make legacy 'y' key default to settarget, and 'alt+y' to #4176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saurtron
Copy link
Collaborator

@saurtron saurtron commented Jan 15, 2025

Work done

  • Invert settarget legacy bindings: do 'y' for settarget and 'alt+y' for settargetnoground

Remarks

  • Grid just has settarget bound to 's'.
    • Maybe grid could also map alt+s to alternative settarget, not sure if that's taken though.
  • This has been causing quite some confusion, and been investigated as a bug since months XD
  • cons: Changing this could be confusing for users currently happy with settargetnoground on 'y', but at least some are getting bewildered when they can't settarget at ghosts from far away, and ground generally.
  • Change might not be wanted, but anyways hope this issue helps in raising awareness.
    • otherwise, settargetnoground should have some visual confirmation, maybe, about when a valid target is under cursor (actually settarget would also benefit from this)

Special thx to 'Graceful' at discord for reporting and finding what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant